netdev - Re: [PATCH net-next v3 6/7] net: phy: smsc: Cache interrupt mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220512121717.GD4703@wunner.de>
Date:   Thu, 12 May 2022 14:17:17 +0200
From:   Lukas Wunner <lukas@...ner.de>
To:     netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v3 6/7] net: phy: smsc: Cache interrupt mask

On Thu, May 12, 2022 at 10:42:06AM +0200, Lukas Wunner wrote:
> Cache the interrupt mask to avoid re-reading it from the PHY upon every
> interrupt.
> 
> This will simplify a subsequent commit which detects hot-removal in the
> interrupt handler and bails out.
> 
> Analyzing and debugging PHY transactions also becomes simpler if such
> redundant reads are avoided.
> 
> Last not least, interrupt overhead and latency is slightly improved.
> 
> Tested-by: Oleksij Rempel <o.rempel@...gutronix.de> # LAN9514/9512/9500
> Tested-by: Ferry Toth <fntoth@...il.com> # LAN9514
> Signed-off-by: Lukas Wunner <lukas@...ner.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

Andrew kindly provided this tag here:
https://lore.kernel.org/netdev/YnGsDtscYkh28PFm@lunn.ch/

Forgot to add it to the commit.
Sending it in separately so patchwork picks it up.
My apologies for the inconvenience.