lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 12 May 2022 22:59:31 +0200
From:   Daniel Borkmann <>
To:     liqiong <>, Yonghong Song <>,
        Andrii Nakryiko <>,
        Martin KaFai Lau <>,
        Song Liu <>
Cc:     Alexei Starovoitov <>,
        John Fastabend <>,
        KP Singh <>,,,,,,,
Subject: Re: [PATCH 1/2] kernel/bpf: change "char *" string form to "char []"

On 5/12/22 7:08 PM, liqiong wrote:
> 在 2022年05月12日 23:16, Yonghong Song 写道:
>> On 5/12/22 7:28 AM, liqiong wrote:
>>> The string form of "char []" declares a single variable. It is better
>>> than "char *" which creates two variables.
>> Could you explain in details about why it is better in generated codes?
>> It is not clear to me why your patch is better than the original code.
> The  string form of "char *" creates two variables in the final assembly output,
> a static string, and a char pointer to the static string.  Use  "objdump -S -D  *.o",
> can find out the static string  occurring  at "Contents of section .rodata".

There are ~360 instances of this type in the tree from a quick grep, do you
plan to convert all them ?


Powered by blists - more mailing lists