lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 May 2022 11:48:24 -0700 From: Eric Dumazet <edumazet@...gle.com> To: Jakub Kicinski <kuba@...nel.org> Cc: Oliver Hartkopp <socketcan@...tkopp.net>, Eric Dumazet <eric.dumazet@...il.com>, "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH v2 net-next] inet: add READ_ONCE(sk->sk_bound_dev_if) in INET_MATCH() On Fri, May 13, 2022 at 10:18 AM Jakub Kicinski <kuba@...nel.org> wrote: > > On Thu, 12 May 2022 10:14:23 -0700 Eric Dumazet wrote: > > On Thu, May 12, 2022 at 10:02 AM Oliver Hartkopp <socketcan@...tkopp.net> wrote: > > > > > When you convert the #define into an inline function, wouldn't it be > > > more natural to name it lower caps? > > > > > > static inline bool inet_match(struct net *net, ... ) > > > > Sure, it is only a matter for us to remember all the past/present > > names, based on implementation details, especially at backport times. > > We can apply as is if you prefer, but I'm not sure I follow TBH. > The prototype (arguments) of the function/macro have changed so there > is nothing to be gained from not changing the name AFAICT, no? This was applied by David, I will send the v2 of the series, and a patch renaming INET_MATCH(). Thanks.
Powered by blists - more mailing lists