netdev - RE: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fb9d491692a4a2dabe783ffefc76ded@realtek.com>
Date:   Mon, 23 May 2022 02:35:32 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "johannes@...solutions.net" <johannes@...solutions.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "colin.king@...el.com" <colin.king@...el.com>
Subject: RE: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12


> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Saturday, May 21, 2022 3:43 AM
> To: kvalo@...nel.org; johannes@...solutions.net
> Cc: netdev@...r.kernel.org; linux-wireless@...r.kernel.org; Jakub Kicinski <kuba@...nel.org>; Pkshih
> <pkshih@...ltek.com>; keescook@...omium.org; colin.king@...el.com
> Subject: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12
> 
> The .value is a two-dim array, not a pointer.
> 
> struct iqk_matrix_regs {
> 	bool iqk_done;
>         long value[1][IQK_MATRIX_REG_NUM];
> };
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: pkshih@...ltek.com
> CC: kvalo@...nel.org
> CC: keescook@...omium.org
> CC: colin.king@...el.com
> CC: linux-wireless@...r.kernel.org
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index 51fe51bb0504..15e6a6aded31 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -2386,10 +2386,7 @@ void rtl92d_phy_reload_iqk_setting(struct ieee80211_hw *hw, u8 channel)
>  			rtl_dbg(rtlpriv, COMP_SCAN, DBG_LOUD,
>  				"Just Read IQK Matrix reg for channel:%d....\n",
>  				channel);
> -			if ((rtlphy->iqk_matrix[indexforchannel].
> -			     value[0] != NULL)

This is a typo since initial commit. Correct it by
-			     value[0] != NULL)
+			     value[0][0] != 0)

So, NACK this patch.

--
Ping-Ke