netdev - Re: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 08:57:01 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ping-Ke Shih <pkshih@...ltek.com>
Cc:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "colin.king@...el.com" <colin.king@...el.com>
Subject: Re: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true
 condition pointed out by GCC 12

On Mon, 23 May 2022 02:35:32 +0000 Ping-Ke Shih wrote:
> This is a typo since initial commit. Correct it by
> -			     value[0] != NULL)
> +			     value[0][0] != 0)
> 
> So, NACK this patch.

Too, late, the patches were already applied, sorry. Please post a fixup.