netdev - Re: [PATCH net-next 3/3] ice: add write functionality for GNSS TTY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB580076B10F2B898C644D8C3686D49@MW4PR11MB5800.namprd11.prod.outlook.com>
Date:   Mon, 23 May 2022 16:58:27 +0000
From:   "Kolacinski, Karol" <karol.kolacinski@...el.com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "G, GurucharanX" <gurucharanx.g@...el.com>
Subject: Re: [PATCH net-next 3/3] ice: add write functionality for GNSS TTY

On Thu, 19 May 2022 15:45 +0200 Paolo Abeni wrote
> > +
> > +exit:
> > +     if (err)
> > +             dev_err(ice_pf_to_dev(pf), "GNSS failed to write, offset=%u, size=%u, err=%d\n",
> > +                     offset, size, err);
> > +
> > +     return offset;
> 
> 
> IMHO more readable with:
>         if (err)
>                 goto err_out;
> 
>         return size;
> 
> err_out:
>         dev_err(ice_pf_to_dev(pf), "GNSS failed to write, offset=%u, size=%u, err=%d\n",
>                         offset, size, err);
>         return offset;
> 
> (plus adjusting the goto above)
> 
> Thanks!
> 
> Paolo

Done, looks better, thanks!

Karol