netdev - Re: [PATCH net-next 2/3] ice: add i2c write command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 17:02:55 +0000
From:   "Kolacinski, Karol" <karol.kolacinski@...el.com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "G, GurucharanX" <gurucharanx.g@...el.com>
Subject: Re: [PATCH net-next 2/3] ice: add i2c write command

> On Thu, 19 May 2022 15:40 +0200 Paolo Abeni wrote:
> > +     for (i = 0; i < data_size; i++) {
> > +             cmd->i2c_data[i] = *data;
> > +             data++;
> > +     }
> Why not:
>         memcpy(cmd->i2c_data, data, data_size);
> 
>         ?
> 
> Thanks!
> 
> Paolo

Nice catch, thanks!

Karol