netdev - Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 May 2022 09:43:30 +0200 (CEST)
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
cc:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
        netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        corbet@....net, tsbogend@...ha.franken.de, mpe@...erman.id.au,
        paulus@...ba.org, sburla@...vell.com, vburru@...vell.com,
        aayarekar@...vell.com, arnd@...db.de, zhangyue1@...inos.cn,
        linux-doc@...r.kernel.org, linux-mips@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-parisc@...r.kernel.org
Subject: Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip
 & DIGITAL EtherWORKS PCI/EISA

 	Hi Ben,

On Sat, 21 May 2022, Benjamin Herrenschmidt wrote:
> On Wed, 2022-05-18 at 20:13 -0700, Jakub Kicinski wrote:
>> Looks like almost all changes to this driver had been tree-wide
>> refactoring since git era begun. There is one commit from Al
>> 15 years ago which could potentially be fixing a real bug.
>>
>> The driver is using virt_to_bus() and is a real magnet for pointless
>> cleanups. It seems unlikely to have real users. Let's try to shed
>> this maintenance burden.
>>
>> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>
> Removing this driver will kill support for some rather old PowerMac
> models (some PowerBooks I think, paulus would know). No objection on my
> part, though. I doubt people still use these things with new kernels
> but ... who knows ? :-)

Aren't these PCI, and thus working fine with the PCI-only DE2104X
(dc2104x) or TULIP (dc2114x) drivers?

IIRC, I've initially used the de4x5 driver on Alpha (UDB/Multia) or PPC
(CHRP), but switched to the TULIP driver later (that was before the
dc2104x/dc2114x driver split, hence a loooong time ago).

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds