netdev - Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1z5_QBMq+X53wN=xP4_00ahrQDpz7Kd3GJCK-9Mn9AQQ@mail.gmail.com>
Date:   Thu, 26 May 2022 10:17:14 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Michael Ellerman <mpe@...erman.id.au>,
        Paul Mackerras <paulus@...ba.org>, sburla@...vell.com,
        vburru@...vell.com, aayarekar@...vell.com,
        Arnd Bergmann <arnd@...db.de>, zhangyue1@...inos.cn,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Parisc List <linux-parisc@...r.kernel.org>
Subject: Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip &
 DIGITAL EtherWORKS PCI/EISA

On Thu, May 26, 2022 at 9:43 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Sat, 21 May 2022, Benjamin Herrenschmidt wrote:
> > On Wed, 2022-05-18 at 20:13 -0700, Jakub Kicinski wrote:
> >> Looks like almost all changes to this driver had been tree-wide
> >> refactoring since git era begun. There is one commit from Al
> >> 15 years ago which could potentially be fixing a real bug.
> >>
> >> The driver is using virt_to_bus() and is a real magnet for pointless
> >> cleanups. It seems unlikely to have real users. Let's try to shed
> >> this maintenance burden.
> >>
> >> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> >
> > Removing this driver will kill support for some rather old PowerMac
> > models (some PowerBooks I think, paulus would know). No objection on my
> > part, though. I doubt people still use these things with new kernels
> > but ... who knows ? :-)
>
> Aren't these PCI, and thus working fine with the PCI-only DE2104X
> (dc2104x) or TULIP (dc2114x) drivers?
>
> IIRC, I've initially used the de4x5 driver on Alpha (UDB/Multia) or PPC
> (CHRP), but switched to the TULIP driver later (that was before the
> dc2104x/dc2114x driver split, hence a loooong time ago).

The PCI device IDs say this is correct: there are four IDs in the
de4x5 driver, all of which are also listed in one of the two other
drivers.

      Arnd