netdev - Re: [PATCH net] bonding: show NS IPv6 targets in proc master info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e09cd8cf-4779-273e-a354-c1cfba120305@redhat.com>
Date:   Fri, 27 May 2022 10:13:08 -0400
From:   Jonathan Toppins <jtoppins@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, Li Liang <liali@...hat.com>
Subject: Re: [PATCH net] bonding: show NS IPv6 targets in proc master info

On 5/27/22 02:44, Hangbin Liu wrote:
> When adding bond new parameter ns_targets. I forgot to print this
> in bond master proc info. After updating, the bond master info will looks
                                                                look ---^
> like:
> 
> ARP IP target/s (n.n.n.n form): 192.168.1.254
> NS IPv6 target/s (XX::XX form): 2022::1, 2022::2
> 
> Fixes: 4e24be018eb9 ("bonding: add new parameter ns_targets")
> Reported-by: Li Liang <liali@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>   drivers/net/bonding/bond_procfs.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c
> index cfe37be42be4..b6c012270e2e 100644
> --- a/drivers/net/bonding/bond_procfs.c
> +++ b/drivers/net/bonding/bond_procfs.c
> @@ -129,6 +129,19 @@ static void bond_info_show_master(struct seq_file *seq)
>   			printed = 1;
>   		}
>   		seq_printf(seq, "\n");

Does this need to be guarded by "#if IS_ENABLED(CONFIG_IPV6)"?
> +
> +		printed = 0;
> +		seq_printf(seq, "NS IPv6 target/s (xx::xx form):");
> +
> +		for (i = 0; (i < BOND_MAX_NS_TARGETS); i++) {
> +			if (ipv6_addr_any(&bond->params.ns_targets[i]))
> +				break;
> +			if (printed)
> +				seq_printf(seq, ",");
> +			seq_printf(seq, " %pI6c", &bond->params.ns_targets[i]);
> +			printed = 1;
> +		}
> +		seq_printf(seq, "\n");
>   	}
>   
>   	if (BOND_MODE(bond) == BOND_MODE_8023AD) {