netdev - Re: [PATCH iproute2-next 09/10] ipstats: Expose bond stats in ipstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pmjzhvvd.fsf@nvidia.com>
Date:   Fri, 27 May 2022 16:50:12 +0200
From:   Petr Machata <petrm@...dia.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     Petr Machata <petrm@...dia.com>, <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH iproute2-next 09/10] ipstats: Expose bond stats in ipstats


Stephen Hemminger <stephen@...workplumber.org> writes:

> This change won't build if clang is used to build iproute2.
> It has valid warning:
>
>     CC       iplink_bond.o
> iplink_bond.c:935:10: error: initializer element is not a compile-time constant
>         .desc = ipstats_stat_desc_bond_tmpl_lacp,
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> iplink_bond.c:957:10: error: initializer element is not a compile-time constant
>         .desc = ipstats_stat_desc_bond_tmpl_lacp,
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 2 errors generated.
>
> Since desc is a structure, you can't just assign an existing data structure
> to the new initializer.  It needs to be a pointer or macro.

Yeah, it has to be a macro. I'll send a patch probably next week.