netdev - Re: [PATCH v2] net: phy: at803x: disable WOL at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165397201170.21793.7926133541403141360.git-patchwork-notify@kernel.org>
Date:   Tue, 31 May 2022 04:40:11 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Viorel Suman (OSS) <viorel.suman@....nxp.com>
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, luoj@...eaurora.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-imx@....com,
        viorel.suman@....com
Subject: Re: [PATCH v2] net: phy: at803x: disable WOL at probe

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 27 May 2022 11:49:34 +0300 you wrote:
> From: Viorel Suman <viorel.suman@....com>
> 
> Before 7beecaf7d507b ("net: phy: at803x: improve the WOL feature") patch
> "at803x_get_wol" implementation used AT803X_INTR_ENABLE_WOL value to set
> WAKE_MAGIC flag, and now AT803X_WOL_EN value is used for the same purpose.
> The problem here is that the values of these two bits are different after
> hardware reset: AT803X_INTR_ENABLE_WOL=0 after hardware reset, but
> AT803X_WOL_EN=1. So now, if called right after boot, "at803x_get_wol" will
> set WAKE_MAGIC flag, even if WOL function is not enabled by calling
> "at803x_set_wol" function. The patch disables WOL function on probe thus
> the behavior is consistent.
> 
> [...]

Here is the summary with links:
  - [v2] net: phy: at803x: disable WOL at probe
    https://git.kernel.org/netdev/net/c/d7cd5e06c9dd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html