netdev - Re: [PATCH net-next v4] net: txgbe: Add build support for txgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 May 2022 13:27:54 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Jiawen Wu <jiawenwu@...stnetic.com>
Subject: Re: [PATCH net-next v4] net: txgbe: Add build support for txgbe

Hi Jiawen,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Jiawen-Wu/net-txgbe-Add-build-support-for-txgbe/20220531-112035
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7e062cda7d90543ac8c7700fc7c5527d0c0f22ad
config: alpha-defconfig (https://download.01.org/0day-ci/archive/20220531/202205311308.X0cnd1ha-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/52085d783a4667549a5f4224135c71c0a643bec0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jiawen-Wu/net-txgbe-Add-build-support-for-txgbe/20220531-112035
        git checkout 52085d783a4667549a5f4224135c71c0a643bec0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/pci/quirks.c:5911:60: error: unterminated argument list invoking macro "DECLARE_PCI_FIXUP_HEADER"
    5911 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_WANGXUN, PCI_ANY_ID,
         |                                                            ^
>> drivers/pci/quirks.c:5911:1: error: expected '=', ',', ';', 'asm' or '__attribute__' at end of input
    5911 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_WANGXUN, PCI_ANY_ID,
         | ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/pci/quirks.c:5899:13: warning: 'quirk_wangxun_set_read_req_size' defined but not used [-Wunused-function]
    5899 | static void quirk_wangxun_set_read_req_size(struct pci_dev *pdev)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/DECLARE_PCI_FIXUP_HEADER +5911 drivers/pci/quirks.c

  5898	
  5899	static void quirk_wangxun_set_read_req_size(struct pci_dev *pdev)
  5900	{
  5901		u16 ctl;
  5902	
  5903		pcie_capability_read_word(pdev, PCI_EXP_DEVCTL, &ctl);
  5904	
  5905		if (((ctl & PCI_EXP_DEVCTL_READRQ) != PCI_EXP_DEVCTL_READRQ_128B) &&
  5906		    ((ctl & PCI_EXP_DEVCTL_READRQ) != PCI_EXP_DEVCTL_READRQ_256B))
  5907			pcie_capability_clear_and_set_word(pdev, PCI_EXP_DEVCTL,
  5908							   PCI_EXP_DEVCTL_READRQ,
  5909							   PCI_EXP_DEVCTL_READRQ_256B);
  5910	}
> 5911	DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_WANGXUN, PCI_ANY_ID,

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp