netdev - Re: [PATCH net-next v1 1/2] net: Update bhash2 when socket's rcv saddr changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJnrk1bkLFwAmmQviJeeHKSHygUqG8LH81RYnx6+mJOLZF8tjw@mail.gmail.com>
Date:   Wed, 1 Jun 2022 11:31:08 -0700
From:   Joanne Koong <joannelkoong@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        netdev <netdev@...r.kernel.org>, Martin KaFai Lau <kafai@...com>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        richard_siegfried@...temli.org, dsahern@...nel.org,
        yoshfuji@...ux-ipv6.org, kuniyu@...zon.co.jp, dccp@...r.kernel.org,
        testing@...r.kernel.org,
        syzbot <syzbot+015d756bbd1f8b5c8f09@...kaller.appspotmail.com>
Subject: Re: [PATCH net-next v1 1/2] net: Update bhash2 when socket's rcv
 saddr changes

On Wed, Jun 1, 2022 at 2:58 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> Hello,
>
> On Tue, 2022-05-31 at 15:04 -0700, Eric Dumazet wrote:
> > On Tue, May 24, 2022 at 4:20 PM Joanne Koong <joannelkoong@...il.com> wrote:
> > >
> > > Commit d5a42de8bdbe ("net: Add a second bind table hashed by port and
> > > address") added a second bind table, bhash2, that hashes by a socket's port
> > > and rcv address.
> > >
> > > However, there are two cases where the socket's rcv saddr can change
> > > after it has been binded:
> > >
> > > 1) The case where there is a bind() call on "::" (IPADDR_ANY) and then
> > > a connect() call. The kernel will assign the socket an address when it
> > > handles the connect()
> > >
> > > 2) In inet_sk_reselect_saddr(), which is called when rerouting fails
> > > when rebuilding the sk header (invoked by inet_sk_rebuild_header)
> > >
> > > In these two cases, we need to update the bhash2 table by removing the
> > > entry for the old address, and adding a new entry reflecting the updated
> > > address.
> > >
> > > Reported-by: syzbot+015d756bbd1f8b5c8f09@...kaller.appspotmail.com
> > > Fixes: d5a42de8bdbe ("net: Add a second bind table hashed by port and address")
> > > Signed-off-by: Joanne Koong <joannelkoong@...il.com>
> > > ---
> >
> > Reviewed-by: Eric Dumazet <edumzet@...gle.com>
> >
> Apparently this patch (and 2/2) did not reach the ML nor patchwork (let
> alone my inbox ;). I've no idea on the root cause, sorry.
>
> @Joanne: could you please re-post the series? (you can retain Eric's
> review tag)
>
For some reason, my patches recently haven't been getting through to
the netdev mailing list but they've been going through ok to the bpf
one; John, Jakub, and I are looking into it and doing some
investigations :)

I will resend this series again.

Thanks for taking a look at this patchset, Eric and Paolo.
> Thanks!
>
> Paolo
>