netdev - Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1654122203-26090-1-git-send-email-sean.wang@mediatek.com>
Date:   Thu, 2 Jun 2022 06:23:23 +0800
From:   <sean.wang@...iatek.com>
To:     <dev@...henker.ch>
CC:     <deren.wu@...iatek.com>, <kvalo@...nel.org>,
        <linux-wireless@...r.kernel.org>, <nbd@....name>,
        <linux@...mhuis.info>, <davem@...emloft.net>, <kuba@...nel.org>,
        <lorenzo.bianconi83@...il.com>, <matthias.bgg@...il.com>,
        <pabeni@...hat.com>, <ryder.lee@...iatek.com>,
        <sean.wang@...iatek.com>, <shayne.chen@...iatek.com>,
        <yn.chen@...iatek.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"

From: Sean Wang <sean.wang@...iatek.com>

>On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
>> On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
>> > Philippe Schenker <dev@...henker.ch> writes:
>> >
>> > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
>> > >
>> > > This commit introduces a regression on some systems where the
>> > > kernel is crashing in different locations after a reboot was
>> > > issued.
>> > >
>> > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest
>> > > firmware.
>> > >
>> > > Link:
>> > > https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless
>> > > /5077a953487275837e81bdf1808ded00b9676f9f.camel@...henker.ch/__;!!
>> > > CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14
>> > > J4iDycWA9cq36Y$
>> > >
>> > > Signed-off-by: Philippe Schenker <dev@...henker.ch>
>> >
>> > Can I take this to wireless tree? Felix, ack?
>> >
>> > I'll also add:
>> >
>> > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
>> >
>>
>> Hi Kalle,
>>
>> We have a patch for a similar problem. Can you wait for the
>> verification by Philippe?
>> Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure
>> after
>> reboot")
>> Link:
>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kerne
>> l/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76?id=
>> 602cc0c9618a819ab00ea3c9400742a0ca318380__;!!CTRNKA9wMg0ARbw!3N9I3iKwS
>> 3XCNAb4LuhbFqt_el1yiOaJzSdUjaJsTaxRCHiWhXnEgbk3bOqYTy6T$
>>
>> I can reproduce the problem in my v5.16-rc5 desktop. And the issue can
>> be fixed when the patch applied.
>>
>>
>> Hi Philippe,
>>
>> Can you please help to check the patch in your platform?
>
>Hi Kalle and Deren,
>
>I just noticed on my system and mainline v5.18 reboots do now work however Bluetooth is no longer accessible after a reboot.
>
>Reverting commit bf3747ae2e25dda6a9e6c464a717c66118c588c8 on top of
>v5.18 solves this problem for me.
>
>@Deren are you aware of this bug?
>@Kalle Is there a bugtracker somewhere I can submit this?

Hi Philippe,

Could you try the latest firmware to see if it can help with the issue you reported here ?

Please check out https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/mediatek
and replace the following three files in /lib/firmware/mediatek on your target and reboot
1) BT_RAM_CODE_MT7961_1_2_hdr.bin
2) WIFI_MT7961_patch_mcu_1_2_hdr.bin
3) WIFI_RAM_CODE_MT7961_1.bin

	Sean

>
>Thanks,
>Philippe
>
>>
>>
>> Regards,
>> Deren
>>
>
>
>