netdev - Re: [PATCHv2 0/3] perf tools: Fix prologue generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZrd4mXtGXmiH3VCCYtQacG1n9+3eJbtdAZJi5SW_Mj6A@mail.gmail.com>
Date:   Wed, 1 Jun 2022 15:21:06 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jiri Olsa <olsajiri@...il.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        "linux-perf-use." <linux-perf-users@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        Ian Rogers <irogers@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCHv2 0/3] perf tools: Fix prologue generation

On Wed, Jun 1, 2022 at 11:11 AM Jiri Olsa <olsajiri@...il.com> wrote:
>
> On Thu, May 26, 2022 at 10:16:11PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, May 10, 2022 at 09:46:56AM +0200, Jiri Olsa escreveu:
> > > hi,
> > > sending change we discussed some time ago [1] to get rid of
> > > some deprecated functions we use in perf prologue code.
> > >
> > > Despite the gloomy discussion I think the final code does
> > > not look that bad ;-)
> > >
> > > This patchset removes following libbpf functions from perf:
> > >   bpf_program__set_prep
> > >   bpf_program__nth_fd
> > >   struct bpf_prog_prep_result
> >
> > So, the first patch is already in torvalds/master, I tried applying the
> > other two patches to my local perf/core, that already is merged with
> > torvalds/master and:
> >
> > [root@...co ~]# perf test 42
> >  42: BPF filter                                                      :
> >  42.1: Basic BPF filtering                                           : FAILED!
> >  42.2: BPF pinning                                                   : FAILED!
> >  42.3: BPF prologue generation                                       : FAILED!
> > [root@...co ~]#
> >
> > I'll push my local perf/core to tmp.perf/core and continue tomorrow.
>
> hi,
> I just rebased my changes on top of your perf/core and it seems to work:
>
>         [root@...va perf]# ./perf test bpf
>          40: LLVM search and compile                                         :
>          40.1: Basic BPF llvm compile                                        : Ok
>          40.3: Compile source for BPF prologue generation                    : Ok
>          40.4: Compile source for BPF relocation                             : Ok
>          42: BPF filter                                                      :
>          42.1: Basic BPF filtering                                           : Ok
>          42.2: BPF pinning                                                   : Ok
>          42.3: BPF prologue generation                                       : Ok
>
> is it still a problem?
>

Ok, so I checked with Jakub, net-next will be forwarded to
linus/master tomorrow or so, so after that bpf-next will get forwarded
as well and we'll have all those patches of yours. So let's go back to
plan A: send your perf changes based on bpf-next. Thanks and sorry for
the extra noise with all the back and forth.


> jirka