netdev - Re: [PATCH net V3] net: ping6: Fix ping -6 with interface name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77a41c44-9b10-3aa7-8899-9c251865de94@nvidia.com>
Date:   Wed, 1 Jun 2022 12:40:42 +0300
From:   Aya Levin <ayal@...dia.com>
To:     David Ahern <dsahern@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Paolo Abeni <pabeni@...hat.com>, Gal Pressman <gal@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net V3] net: ping6: Fix ping -6 with interface name



On 5/31/2022 5:31 PM, David Ahern wrote:
> On 5/31/22 2:45 AM, Tariq Toukan wrote:
>> From: Aya Levin <ayal@...dia.com>
>>
>> When passing interface parameter to ping -6:
>> $ ping -6 ::11:141:84:9 -I eth2
>> Results in:
>> PING ::11:141:84:10(::11:141:84:10) from ::11:141:84:9 eth2: 56 data bytes
>> ping: sendmsg: Invalid argument
>> ping: sendmsg: Invalid argument
>>
>> Initialize the fl6's outgoing interface (OIF) before triggering
>> ip6_datagram_send_ctl. Don't wipe fl6 after ip6_datagram_send_ctl() as
>> changes in fl6 that may happen in the function are overwritten explicitly.
>> Update comment accordingly.
>>
>> Fixes: 13651224c00b ("net: ping6: support setting basic SOL_IPV6 options via cmsg")
>> Signed-off-by: Aya Levin <ayal@...dia.com>
>> Reviewed-by: Gal Pressman <gal@...dia.com>
>> Reviewed-by: Saeed Mahameed <saeedm@...dia.com>
>> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
>> ---
>>   net/ipv6/ping.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> V3:
>> Per David Ahern's comment, moved fl6.flowi6_oif init to the
>> shared flow right after the memset.
>>
>> V2:
>> Per David Ahern's comment, moved memset before if (msg->msg_controllen),
>> and updated the code comment accordingly.
>>
> 
> Reviewed-by: David Ahern <dsahern@...nel.org>
Thanks for the review.
> 
> The patch set with the Fixes tag added selftests using cmsg_sender.c.
> You can extend it to support IPV6_PKTINFO and submit a selftest for this
> case to -next when it opens.
I'll submit the selftest extension in the coming window
Aya