netdev - Re: [PATCH] net: tulip: de4x5: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Jun 2022 09:06:59 +0800
From:   baihaowen <baihaowen@...zu.com>
To:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
CC:     <netdev@...r.kernel.org>, <linux-parisc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: tulip: de4x5: remove unused variable

在 2022/6/1 下午3:24, Haowen Bai 写道:
> The variable imr is initialized but never used otherwise.
>
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>  drivers/net/ethernet/dec/tulip/de4x5.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c
> index 71730ef4cd57..40a54827d599 100644
> --- a/drivers/net/ethernet/dec/tulip/de4x5.c
> +++ b/drivers/net/ethernet/dec/tulip/de4x5.c
> @@ -3817,10 +3817,9 @@ de4x5_setup_intr(struct net_device *dev)
>  {
>      struct de4x5_private *lp = netdev_priv(dev);
>      u_long iobase = dev->base_addr;
> -    s32 imr, sts;
> +    s32 sts;
>  
>      if (inl(DE4X5_OMR) & OMR_SR) {   /* Only unmask if TX/RX is enabled */
> -	imr = 0;
>  	UNMASK_IRQs;
>  	sts = inl(DE4X5_STS);        /* Reset any pending (stale) interrupts */
>  	outl(sts, DE4X5_STS);
Sorry, ignore this patch.

-- 
Haowen Bai