netdev - Re: [PATCH net-next v1 resend 1/2] net: Update bhash2 when socket's rcv saddr changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220601181304.6459d831@kernel.org>
Date:   Wed, 1 Jun 2022 18:13:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joanne Koong <joannekoong@...com>
Cc:     <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <edumazet@...gle.com>, <kafai@...com>, <davem@...emloft.net>,
        <pabeni@...hat.com>, <testing@...r.kernel.org>,
        Joanne Koong <joannelkoong@...il.com>,
        <syzbot+015d756bbd1f8b5c8f09@...kaller.appspotmail.com>,
        Eric Dumazet <edumzet@...gle.com>
Subject: Re: [PATCH net-next v1 resend 1/2] net: Update bhash2 when socket's
 rcv saddr changes

On Wed, 1 Jun 2022 13:14:33 -0700 Joanne Koong wrote:
> From: Joanne Koong <joannelkoong@...il.com>
> 
> Commit d5a42de8bdbe ("net: Add a second bind table hashed by port and
> address") added a second bind table, bhash2, that hashes by a socket's port
> and rcv address.
> 
> However, there are two cases where the socket's rcv saddr can change
> after it has been binded:
> 
> 1) The case where there is a bind() call on "::" (IPADDR_ANY) and then
> a connect() call. The kernel will assign the socket an address when it
> handles the connect()
> 
> 2) In inet_sk_reselect_saddr(), which is called when rerouting fails
> when rebuilding the sk header (invoked by inet_sk_rebuild_header)
> 
> In these two cases, we need to update the bhash2 table by removing the
> entry for the old address, and adding a new entry reflecting the updated
> address.
> 
> Reported-by: syzbot+015d756bbd1f8b5c8f09@...kaller.appspotmail.com
> Fixes: d5a42de8bdbe ("net: Add a second bind table hashed by port and address")
> Signed-off-by: Joanne Koong <joannelkoong@...il.com>
> Reviewed-by: Eric Dumazet <edumzet@...gle.com>

This one needs to be static:

net/ipv4/inet_hashtables.c:830:5: warning: no previous prototype for ‘__inet_bhash2_update_saddr’ [-Wmissing-prototypes]
  830 | int __inet_bhash2_update_saddr(struct sock *sk, struct inet_hashinfo *hinfo,