netdev - Re: [PATCH net-next 3/5] net: dsa: realtek: rtl8365mb: correct the max number of ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJq09z4f1DN1b=+QONT7ya5nXVQ6m8ZcMDVemmkduWc9mXSTRg@mail.gmail.com>
Date:   Tue, 7 Jun 2022 10:17:56 -0300
From:   Luiz Angelo Daros de Luca <luizluca@...il.com>
To:     Alvin Šipraga <alvin@...s.dk>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 3/5] net: dsa: realtek: rtl8365mb: correct the
 max number of ports

Em seg., 6 de jun. de 2022 às 10:46, Alvin Šipraga <alvin@...s.dk> escreveu:
>
> From: Alvin Šipraga <alsi@...g-olufsen.dk>
>
> The maximum number of ports is actually 11, according to two
> observations:
>
> 1. The highest port ID used in the vendor driver is 10. Since port IDs
>    are indexed from 0, and since DSA follows the same numbering system,
>    this means up to 11 ports are to be presumed.
>
> 2. The registers with port mask fields always amount to a maximum port
>    mask of 0x7FF, corresponding to a maximum 11 ports.
>  /* valid for all 6-port or less variants */

It makes sense for the family. The 10-ports variants have 0-7 user
ports and ext0,1,2 declared in rtl8367c driver, although no model I
know does use ext2.

Reviewed-by: Luiz Angelo Daros de Luca <luizluca@...il.com>