netdev - Re: [PATCH] amd-xgbe: Use platform_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3067cab3-21b3-456a-37a5-f21a349f3b8e@amd.com>
Date:   Mon, 13 Jun 2022 11:39:48 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Jean-Philippe Brucker <jean-philippe@...aro.org>,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com
Cc:     robh@...nel.org, prabhakar.mahadev-lad.rj@...renesas.com,
        maz@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] amd-xgbe: Use platform_irq_count()

On 6/9/22 11:14, Jean-Philippe Brucker wrote:
> The AMD XGbE driver currently counts the number of interrupts assigned
> to the device by inspecting the pdev->resource array. Since commit
> a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT
> core") removed IRQs from this array, the driver now attempts to get all
> interrupts from 1 to -1U and gives up probing once it reaches an invalid
> interrupt index.
> 
> Obtain the number of IRQs with platform_irq_count() instead.
> 
> Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@...aro.org>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

It looks like the CCP driver does a similar loop looking for IRQ resources 
(sp_get_irqs() in drivers/crypto/ccp/sp-platform.c), have you looked at 
fixing that driver, too? I can submit a patch if you hadn't planned on it.

Thanks,
Tom

> ---
>   drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c b/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
> index 4ebd2410185a..4d790a89fe77 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
> @@ -338,7 +338,7 @@ static int xgbe_platform_probe(struct platform_device *pdev)
>   		 *   the PHY resources listed last
>   		 */
>   		phy_memnum = xgbe_resource_count(pdev, IORESOURCE_MEM) - 3;
> -		phy_irqnum = xgbe_resource_count(pdev, IORESOURCE_IRQ) - 1;
> +		phy_irqnum = platform_irq_count(pdev) - 1;
>   		dma_irqnum = 1;
>   		dma_irqend = phy_irqnum;
>   	} else {
> @@ -348,7 +348,7 @@ static int xgbe_platform_probe(struct platform_device *pdev)
>   		phy_memnum = 0;
>   		phy_irqnum = 0;
>   		dma_irqnum = 1;
> -		dma_irqend = xgbe_resource_count(pdev, IORESOURCE_IRQ);
> +		dma_irqend = platform_irq_count(pdev);
>   	}
>   
>   	/* Obtain the mmio areas for the device */