netdev - Re: [PATCH] amd-xgbe: Use platform_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yqdzxlquw2gmiFp8@myrica>
Date:   Mon, 13 Jun 2022 18:28:38 +0100
From:   Jean-Philippe Brucker <jean-philippe@...aro.org>
To:     Tom Lendacky <thomas.lendacky@....com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh@...nel.org,
        prabhakar.mahadev-lad.rj@...renesas.com, maz@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] amd-xgbe: Use platform_irq_count()

On Mon, Jun 13, 2022 at 11:39:48AM -0500, Tom Lendacky wrote:
> On 6/9/22 11:14, Jean-Philippe Brucker wrote:
> > The AMD XGbE driver currently counts the number of interrupts assigned
> > to the device by inspecting the pdev->resource array. Since commit
> > a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT
> > core") removed IRQs from this array, the driver now attempts to get all
> > interrupts from 1 to -1U and gives up probing once it reaches an invalid
> > interrupt index.
> > 
> > Obtain the number of IRQs with platform_irq_count() instead.
> > 
> > Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@...aro.org>
> 
> Acked-by: Tom Lendacky <thomas.lendacky@....com>
> 
> It looks like the CCP driver does a similar loop looking for IRQ resources
> (sp_get_irqs() in drivers/crypto/ccp/sp-platform.c), have you looked at
> fixing that driver, too? I can submit a patch if you hadn't planned on it.

Ah no, I did very briefly look for similar issues but missed it, feel free
to send the patch

Thanks,
Jean