netdev - Re: [PATCHv2 net-next] Bonding: add per-port priority for failover re-selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Jun 2022 22:48:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...il.com>,
        Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCHv2 net-next] Bonding: add per-port priority for failover
 re-selection

Hi Hangbin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Hangbin-Liu/Bonding-add-per-port-priority-for-failover-re-selection/20220615-113309
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6ac6dc746d70ef9b4ac835d98ac1baf63a810c57
config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220616/202206162221.Oqz0N9WH-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/2ab299e7237ababa2ce05baa6035154fa04b272d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hangbin-Liu/Bonding-add-per-port-priority-for-failover-re-selection/20220615-113309
        git checkout 2ab299e7237ababa2ce05baa6035154fa04b272d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/bonding/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/bonding/bond_netlink.c: In function 'bond_slave_changelink':
>> drivers/net/bonding/bond_netlink.c:174:23: error: too few arguments to function '__bond_opt_set'
     174 |                 err = __bond_opt_set(bond, BOND_OPT_PRIO, &newval);
         |                       ^~~~~~~~~~~~~~
   In file included from include/net/bonding.h:31,
                    from drivers/net/bonding/bond_netlink.c:16:
   include/net/bond_options.h:110:5: note: declared here
     110 | int __bond_opt_set(struct bonding *bond, unsigned int option,
         |     ^~~~~~~~~~~~~~


vim +/__bond_opt_set +174 drivers/net/bonding/bond_netlink.c

   138	
   139	static int bond_slave_changelink(struct net_device *bond_dev,
   140					 struct net_device *slave_dev,
   141					 struct nlattr *tb[], struct nlattr *data[],
   142					 struct netlink_ext_ack *extack)
   143	{
   144		struct bonding *bond = netdev_priv(bond_dev);
   145		struct bond_opt_value newval;
   146		int err;
   147	
   148		if (!data)
   149			return 0;
   150	
   151		if (data[IFLA_BOND_SLAVE_QUEUE_ID]) {
   152			u16 queue_id = nla_get_u16(data[IFLA_BOND_SLAVE_QUEUE_ID]);
   153			char queue_id_str[IFNAMSIZ + 7];
   154	
   155			/* queue_id option setting expects slave_name:queue_id */
   156			snprintf(queue_id_str, sizeof(queue_id_str), "%s:%u\n",
   157				 slave_dev->name, queue_id);
   158			bond_opt_initstr(&newval, queue_id_str);
   159			err = __bond_opt_set(bond, BOND_OPT_QUEUE_ID, &newval,
   160					     data[IFLA_BOND_SLAVE_QUEUE_ID], extack);
   161			if (err)
   162				return err;
   163		}
   164	
   165		if (data[IFLA_BOND_SLAVE_PRIO]) {
   166			int prio = nla_get_s32(data[IFLA_BOND_SLAVE_PRIO]);
   167			char prio_str[IFNAMSIZ + 7];
   168	
   169			/* prio option setting expects slave_name:prio */
   170			snprintf(prio_str, sizeof(prio_str), "%s:%d\n",
   171				 slave_dev->name, prio);
   172	
   173			bond_opt_initstr(&newval, prio_str);
 > 174			err = __bond_opt_set(bond, BOND_OPT_PRIO, &newval);
   175			if (err)
   176				return err;
   177		}
   178	
   179		return 0;
   180	}
   181	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp