netdev - Re: [PATCH ethtool] sff-8079/8472: Fix missing sff-8472 output in netlink path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220616195602.2bbfab8d@p1.luc.cera.cz>
Date:   Thu, 16 Jun 2022 19:56:02 +0200
From:   Ivan Vecera <ivecera@...hat.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org, Daniel Juarez <djuarezg@...n.ch>,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH ethtool] sff-8079/8472: Fix missing sff-8472 output in
 netlink path

On Thu, 16 Jun 2022 18:19:45 +0200
Michal Kubecek <mkubecek@...e.cz> wrote:

> On Thu, Jun 16, 2022 at 05:50:09PM +0200, Ivan Vecera wrote:
> > Commit 5b64c66f58d ("ethtool: Add netlink handler for
> > getmodule (-m)") provided a netlink variant for getmodule
> > but also introduced a regression as netlink output is different
> > from ioctl output that provides information from A2h page
> > via sff8472_show_all().
> > 
> > To fix this the netlink path should check a presence of A2h page
> > by value of bit 6 in byte 92 of page A0h and if it is set then
> > get A2h page and call sff8472_show_all().
> > 
> > Fixes: 5b64c66f58d ("ethtool: Add netlink handler for getmodule (-m)")  
> 
> Looks like the leading "2" in commit id got lost and "^M" got into the
> subject somehow. AFAICS this should be
> 
>   Fixes: 25b64c66f58d ("ethtool: Add netlink handler for getmodule (-m)")
> 
> Michal

Will send v2

Ivan