netdev - Re: [PATCH net-next v6] net: txgbe: Add build support for txgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YquDYCltyKfEjA93@lunn.ch>
Date:   Thu, 16 Jun 2022 21:24:16 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jiawen Wu <jiawenwu@...stnetic.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6] net: txgbe: Add build support for txgbe


> +err_ioremap:
> +err_alloc_etherdev:
> +	pci_release_selected_regions(pdev,
> +				     pci_select_bars(pdev, IORESOURCE_MEM));
> +err_pci_reg:
> +err_dma:
> +	pci_disable_device(pdev);
> +	return err;
> +}

It is unusual to have a label without any code. I would suggest you
remove err_ioramp and err_pce_reg.

Apart from that, and assuming the compiler testing does not find
anything:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew