netdev - Re: [PATCH net-next v6] net: txgbe: Add build support for txgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jun 2022 13:29:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6] net: txgbe: Add build support for txgbe

On Thu, 16 Jun 2022 21:24:16 +0200 Andrew Lunn wrote:
> > +err_ioremap:
> > +err_alloc_etherdev:
> > +	pci_release_selected_regions(pdev,
> > +				     pci_select_bars(pdev, IORESOURCE_MEM));
> > +err_pci_reg:
> > +err_dma:
> > +	pci_disable_device(pdev);
> > +	return err;
> > +}  
> 
> It is unusual to have a label without any code. I would suggest you
> remove err_ioramp and err_pce_reg.

IMO it's easier to read the code when the label is named after what it
points to, not where it comes from. The were it comes from information
is rather meaningless. One has to always check both source and
destination to check that the code is correct.

If the label is named after what it jumps to it's possible to validate
that the code is jumping to the correct unroll stage without looking at
the actual error path.