netdev - [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jun 2022 13:19:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        Jakub Kicinski <kuba@...nel.org>,
        kernel test robot <lkp@...el.com>, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk,
        boon.leong.ong@...el.com, rmk+kernel@...linux.org.uk
Subject: [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig

Various builds bots are upset about lack of PHYLINK:

>> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!

Link: https://lore.kernel.org/all/202206182016.Go0zVi4t-lkp@intel.com/
Reported-by: kernel test robot <lkp@...el.com>
Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Signed-off-by: Jakub Kicinski <kuba@...nel.org>
---
CC: andrew@...n.ch
CC: hkallweit1@...il.com
CC: linux@...linux.org.uk
CC: boon.leong.ong@...el.com
CC: rmk+kernel@...linux.org.uk
---
 drivers/net/pcs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig
index 22ba7b0b476d..c3e52fa6ca06 100644
--- a/drivers/net/pcs/Kconfig
+++ b/drivers/net/pcs/Kconfig
@@ -8,6 +8,7 @@ menu "PCS device drivers"
 config PCS_XPCS
 	tristate "Synopsys DesignWare XPCS controller"
 	depends on MDIO_DEVICE && MDIO_BUS
+	select PHYLINK
 	help
 	  This module provides helper functions for Synopsys DesignWare XPCS
 	  controllers.
-- 
2.36.1