netdev - Re: [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202206210551.Fhz4xcTc-lkp@intel.com>
Date:   Tue, 21 Jun 2022 05:49:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        edumazet@...gle.com, pabeni@...hat.com,
        Jakub Kicinski <kuba@...nel.org>,
        kernel test robot <lkp@...el.com>, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk,
        boon.leong.ong@...el.com, rmk+kernel@...linux.org.uk
Subject: Re: [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig

Hi Jakub,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/net-pcs-xpcs-select-PHYLINK-in-Kconfig/20220621-042123
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dbca1596bbb08318f5e3b3b99f8ca0a0d3830a65
config: i386-tinyconfig
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/a3120516f7ee66896bb0d3c90fe653ce0cb3a09f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jakub-Kicinski/net-pcs-xpcs-select-PHYLINK-in-Kconfig/20220621-042123
        git checkout a3120516f7ee66896bb0d3c90fe653ce0cb3a09f
        make W=1 ARCH=i386  tinyconfig
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/net/phy/Kconfig:16:error: recursive dependency detected!
   drivers/net/phy/Kconfig:16: symbol PHYLIB is selected by PHYLINK
   drivers/net/phy/Kconfig:6: symbol PHYLINK is selected by PCS_XPCS
   drivers/net/pcs/Kconfig:8: symbol PCS_XPCS depends on MDIO_DEVICE
   drivers/net/mdio/Kconfig:6: symbol MDIO_DEVICE is selected by PHYLIB
   For a resolution refer to Documentation/kbuild/kconfig-language.rst
   subsection "Kconfig recursive dependency limitations"


vim +16 drivers/net/phy/Kconfig

00db8189d984d6 Andy Fleming        2005-07-30   5  
9525ae83959b60 Russell King        2017-07-25   6  config PHYLINK
9525ae83959b60 Russell King        2017-07-25   7  	tristate
9525ae83959b60 Russell King        2017-07-25   8  	depends on NETDEVICES
9525ae83959b60 Russell King        2017-07-25   9  	select PHYLIB
9525ae83959b60 Russell King        2017-07-25  10  	select SWPHY
9525ae83959b60 Russell King        2017-07-25  11  	help
9525ae83959b60 Russell King        2017-07-25  12  	  PHYlink models the link between the PHY and MAC, allowing fixed
9525ae83959b60 Russell King        2017-07-25  13  	  configuration links, PHYs, and Serdes links with MAC level
9525ae83959b60 Russell King        2017-07-25  14  	  autonegotiation modes.
9525ae83959b60 Russell King        2017-07-25  15  
6073512cc8e2c4 Jerome Brunet       2017-09-18 @16  menuconfig PHYLIB
9e8d438e8ba43a Florian Fainelli    2018-04-27  17  	tristate "PHY Device support and infrastructure"
6073512cc8e2c4 Jerome Brunet       2017-09-18  18  	depends on NETDEVICES
6073512cc8e2c4 Jerome Brunet       2017-09-18  19  	select MDIO_DEVICE
1814cff26739de Bartosz Golaszewski 2020-07-05  20  	select MDIO_DEVRES
6073512cc8e2c4 Jerome Brunet       2017-09-18  21  	help
6073512cc8e2c4 Jerome Brunet       2017-09-18  22  	  Ethernet controllers are usually attached to PHY
6073512cc8e2c4 Jerome Brunet       2017-09-18  23  	  devices.  This option provides infrastructure for
6073512cc8e2c4 Jerome Brunet       2017-09-18  24  	  managing PHY devices.
6073512cc8e2c4 Jerome Brunet       2017-09-18  25  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp