netdev - Re: [PATCH v2] net: helper function for skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220621221240.36c6a3a6@kernel.org>
Date:   Tue, 21 Jun 2022 22:12:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Richard Gobert <richardbgobert@...il.com>
Cc:     davem@...emloft.net, pabeni@...hat.com,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, edumazet@...gle.com,
        willemb@...gle.com, imagedong@...cent.com, talalahmad@...gle.com,
        kafai@...com, vasily.averin@...ux.dev, luiz.von.dentz@...el.com,
        jk@...econstruct.com.au, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: helper function for skb_shift

On Mon, 20 Jun 2022 17:56:48 +0200 Richard Gobert wrote:
> Move the len fields manipulation in the skbs to a helper function.
> There is a comment specifically requesting this and there are several
> other areas in the code displaying the same pattern which can be
> refactored.
> This improves code readability.
> 
> Signed-off-by: Richard Gobert <richardbgobert@...il.com>

That's better, thanks. Please move the helper to skbuff.h
and consider changing the subject from talking about skb_shift() 
which is just one of the users now to mentioning the helper's name.