netdev - [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Jun 2022 13:17:58 +0300
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org
Cc:     rmk+kernel@...linux.org.uk, boon.leong.ong@...el.com,
        andrew@...n.ch, hkallweit1@...il.com,
        Ioana Ciornei <ioana.ciornei@....com>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user

Hide the xpcs Kconfig option from the user so that we do not end up in
a scenario where the xpcs is enabled as a module but phylink is not
enabled at all.

ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!

All the user drivers (stmmac and sja1105) of the xpcs module already
select both PCS_XPCS and PHYLINK, so the dependency is resolved at that
level.

Reported-by: Randy Dunlap <rdunlap@...radead.org>
Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
---
 drivers/net/pcs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig
index 22ba7b0b476d..9eb32220efea 100644
--- a/drivers/net/pcs/Kconfig
+++ b/drivers/net/pcs/Kconfig
@@ -6,7 +6,7 @@
 menu "PCS device drivers"
 
 config PCS_XPCS
-	tristate "Synopsys DesignWare XPCS controller"
+	tristate
 	depends on MDIO_DEVICE && MDIO_BUS
 	help
 	  This module provides helper functions for Synopsys DesignWare XPCS
-- 
2.33.1