netdev - Re: [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220627091209.4262b1d8@kernel.org>
Date:   Mon, 27 Jun 2022 09:12:09 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, rmk+kernel@...linux.org.uk,
        boon.leong.ong@...el.com, andrew@...n.ch, hkallweit1@...il.com,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option
 from the user

On Fri, 24 Jun 2022 13:17:58 +0300 Ioana Ciornei wrote:
> Hide the xpcs Kconfig option from the user so that we do not end up in
> a scenario where the xpcs is enabled as a module but phylink is not
> enabled at all.
> 
> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
> 
> All the user drivers (stmmac and sja1105) of the xpcs module already
> select both PCS_XPCS and PHYLINK, so the dependency is resolved at that
> level.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Oh, somehow I missed this patch on Friday, I applied my own
commit ebeae54d3a77 ("net: pcs: xpcs: depends on PHYLINK in Kconfig")