netdev - Re: [PATCH net-next] net: lan743x: Use correct variable in lan743x_sgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrWbrdSnZqcPFhjs@lunn.ch>
Date:   Fri, 24 Jun 2022 13:10:37 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Bryan Whitehead <bryan.whitehead@...rochip.com>,
        Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: lan743x: Use correct variable in
 lan743x_sgmii_config()

On Thu, Jun 23, 2022 at 04:34:03PM +0300, Dan Carpenter wrote:
> There is a copy and paste bug in lan743x_sgmii_config() so it checks
> if (ret < 0) instead of if (mii_ctl < 0).
> 
> Fixes: 46b777ad9a8c ("net: lan743x: Add support to SGMII 1G and 2.5G")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew