netdev - Re: [PATCH 6/6] i2c: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Jun 2022 09:23:04 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Jeremy Kerr <jk@...econstruct.com.au>
Cc:     Wolfram Sang <wsa@...nel.org>, dri-devel@...ts.freedesktop.org,
        linux-serial@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-mtd@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-crypto@...r.kernel.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-i2c@...r.kernel.org, linux-watchdog@...r.kernel.org,
        acpi4asus-user@...ts.sourceforge.net,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        linux-integrity@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-rtc@...r.kernel.org, netdev@...r.kernel.org,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        chrome-platform@...ts.linux.dev, linux-input@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-media@...r.kernel.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-hwmon@...r.kernel.org,
        Support Opensource <support.opensource@...semi.com>,
        linux-fbdev@...r.kernel.org, patches@...nsource.cirrus.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pwm@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        kasan-dev@...glegroups.com, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void

Hello,

[I dropped nearly all individuals from the Cc: list because various
bounces reported to be unhappy about the long (logical) line.]

On Wed, Jun 29, 2022 at 03:03:54PM +0800, Jeremy Kerr wrote:
> Looks good - just one minor change for the mctp-i2c driver, but only
> worthwhile if you end up re-rolling this series for other reasons:
> 
> > -static int mctp_i2c_remove(struct i2c_client *client)
> > +static void mctp_i2c_remove(struct i2c_client *client)
> >  {
> >         struct mctp_i2c_client *mcli = i2c_get_clientdata(client);
> >         struct mctp_i2c_dev *midev = NULL, *tmp = NULL;
> > @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)
> >         mctp_i2c_free_client(mcli);
> >         mutex_unlock(&driver_clients_lock);
> >         /* Callers ignore return code */
> > -       return 0;
> >  }
> 
> The comment there no longer makes much sense, I'd suggest removing that
> too.

Yeah, that was already pointed out to me in a private reply. It's
already fixed in

	https://git.pengutronix.de/cgit/ukl/linux/log/?h=i2c-remove-void

> Either way:
> 
> Reviewed-by: Jeremy Kerr <jk@...econstruct.com.au>

Added to my tree, too.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)