netdev - Re: [PATCH 6/6] i2c: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7654a74e-a410-a8a5-c228-d006dbbc200f@redhat.com>
Date:   Wed, 29 Jun 2022 09:37:08 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Jeremy Kerr <jk@...econstruct.com.au>
Cc:     linux-fbdev@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        platform-driver-x86@...r.kernel.org, linux-mtd@...ts.infradead.org,
        linux-i2c@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-rtc@...r.kernel.org, chrome-platform@...ts.linux.dev,
        linux-staging@...ts.linux.dev, kasan-dev@...glegroups.com,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        linux-serial@...r.kernel.org, linux-input@...r.kernel.org,
        linux-media@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-watchdog@...r.kernel.org, linux-pm@...r.kernel.org,
        acpi4asus-user@...ts.sourceforge.net, linux-gpio@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-arm-kernel@...ts.infradead.org, linux-hwmon@...r.kernel.org,
        Support Opensource <support.opensource@...semi.com>,
        netdev@...r.kernel.org, Wolfram Sang <wsa@...nel.org>,
        linux-crypto@...r.kernel.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        patches@...nsource.cirrus.com, linux-integrity@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void

On 6/29/22 09:23, Uwe Kleine-König wrote:
> Hello,
> 
> [I dropped nearly all individuals from the Cc: list because various
> bounces reported to be unhappy about the long (logical) line.]
>

Yes, it also bounced for me when I tried to reply earlier today.

> diff --git a/drivers/gpu/drm/solomon/ssd130x-i2c.c b/drivers/gpu/drm/solomon/ssd130x-i2c.c
> index 1e0fcec7be47..ddfa0bb5d9c9 100644
> --- a/drivers/gpu/drm/solomon/ssd130x-i2c.c
> +++ b/drivers/gpu/drm/solomon/ssd130x-i2c.c
> @@ -39,13 +39,11 @@ static int ssd130x_i2c_probe(struct i2c_client *client)
>  	return 0;
>  }
>  
> -static int ssd130x_i2c_remove(struct i2c_client *client)
> +static void ssd130x_i2c_remove(struct i2c_client *client)
>  {
>  	struct ssd130x_device *ssd130x = i2c_get_clientdata(client);
>  
>  	ssd130x_remove(ssd130x);
> -
> -	return 0;
>  }
>  
>  static void ssd130x_i2c_shutdown(struct i2c_client *client)

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com> 
-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat