netdev - Re: [PATCH 6/6] i2c: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5517f329-b6ba-efbd-ccab-3d5caa658b80@csgroup.eu>
Date:   Wed, 29 Jun 2022 07:55:38 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Jeremy Kerr <jk@...econstruct.com.au>
CC:     "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "chrome-platform@...ts.linux.dev" <chrome-platform@...ts.linux.dev>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "acpi4asus-user@...ts.sourceforge.net" 
        <acpi4asus-user@...ts.sourceforge.net>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-rpi-kernel@...ts.infradead.org" 
        <linux-rpi-kernel@...ts.infradead.org>,
        "openipmi-developer@...ts.sourceforge.net" 
        <openipmi-developer@...ts.sourceforge.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        Support Opensource <support.opensource@...semi.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Wolfram Sang <wsa@...nel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void



Le 29/06/2022 à 09:23, Uwe Kleine-König a écrit :
> Hello,
> 
> [I dropped nearly all individuals from the Cc: list because various
> bounces reported to be unhappy about the long (logical) line.]

Good idea, even patchwork made a mess of it, see 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220628140313.74984-7-u.kleine-koenig@pengutronix.de/

> 
> On Wed, Jun 29, 2022 at 03:03:54PM +0800, Jeremy Kerr wrote:
>> Looks good - just one minor change for the mctp-i2c driver, but only
>> worthwhile if you end up re-rolling this series for other reasons:
>>
>>> -static int mctp_i2c_remove(struct i2c_client *client)
>>> +static void mctp_i2c_remove(struct i2c_client *client)
>>>   {
>>>          struct mctp_i2c_client *mcli = i2c_get_clientdata(client);
>>>          struct mctp_i2c_dev *midev = NULL, *tmp = NULL;
>>> @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)
>>>          mctp_i2c_free_client(mcli);
>>>          mutex_unlock(&driver_clients_lock);
>>>          /* Callers ignore return code */
>>> -       return 0;
>>>   }
>>
>> The comment there no longer makes much sense, I'd suggest removing that
>> too.
> 
> Yeah, that was already pointed out to me in a private reply. It's
> already fixed in
> 
> 	https://git.pengutronix.de/cgit/ukl/linux/log/?h=i2c-remove-void
> 
>> Either way:
>>
>> Reviewed-by: Jeremy Kerr <jk@...econstruct.com.au>
> 
> Added to my tree, too.
> 
> Thanks
> Uwe
>