lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Jul 2022 02:45:10 +0000 From: Wei Fang <wei.fang@....com> To: Ahmad Fatoum <a.fatoum@...gutronix.de>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de> CC: Aisheng Dong <aisheng.dong@....com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Peng Fan <peng.fan@....com>, Jacky Bai <ping.bai@....com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>, "kernel@...gutronix.de" <kernel@...gutronix.de>, "sudeep.holla@....com" <sudeep.holla@....com>, "festevam@...il.com" <festevam@...il.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: RE: [EXT] Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support Hi Ahmad: Thanks for your reply. clock_ext_rmii and clock_ext_ts indeed belong into board DT, I will move them to imx.8ulp-evk.dts and resubmit the patch. And refer to imx8ulp reference manual, the enet_clk_ref only has external clock source, so it is related to specifical board. Therefore, can I delete the enet_clk_ref clock in imx8ulp.dtsi (as shown below) and override the clock and clock-names properties in imx8ulp-evk.dts ? > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>, > + <&pcc4 IMX8ULP_CLK_ENET>, > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>; > + clock-names = "ipg", "ahb", "ptp"; -----Original Message----- From: Ahmad Fatoum <a.fatoum@...gutronix.de> Sent: 2022年7月4日 15:07 To: Wei Fang <wei.fang@....com>; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org; shawnguo@...nel.org; s.hauer@...gutronix.de Cc: Aisheng Dong <aisheng.dong@....com>; devicetree@...r.kernel.org; Peng Fan <peng.fan@....com>; Jacky Bai <ping.bai@....com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>; kernel@...gutronix.de; sudeep.holla@....com; festevam@...il.com; linux-arm-kernel@...ts.infradead.org Subject: [EXT] Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support Caution: EXT Email Hello Wei, On 04.07.22 12:10, Wei Fang wrote: > + clock_ext_rmii: clock-ext-rmii { > + compatible = "fixed-clock"; > + clock-frequency = <50000000>; > + #clock-cells = <0>; > + clock-output-names = "ext_rmii_clk"; > + }; > + > + clock_ext_ts: clock-ext-ts { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-output-names = "ext_ts_clk"; > + }; How are these SoC-specific? They sound like they belong into board DT. > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>, > + <&pcc4 IMX8ULP_CLK_ENET>, > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>, > + <&clock_ext_rmii>; > + clock-names = "ipg", "ahb", "ptp", > + "enet_clk_ref"; I think the default should be the other way round, assume MAC to provide reference clock and allow override on board-level if PHY does it instead. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pengutronix.de%2F&data=05%7C01%7Cwei.fang%40nxp.com%7C9dad0367d54b427c5e8008da5d8bd912%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637925152473535653%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3tkqsToqq7%2BvNDkC7ZaMm0DsisugDpkVQXCr2zqPbF8%3D&reserved=0 | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists