lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220705183741.35387e3f@rorschach.local.home> Date: Tue, 5 Jul 2022 18:37:41 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: LKML <linux-kernel@...r.kernel.org> Cc: David Ahern <dsahern@...il.com>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: [PATCH] neighbor: tracing: Have neigh_create event use __string() From: "Steven Rostedt (Google)" <rostedt@...dmis.org> The dev field of the neigh_create event uses __dynamic_array() with a fixed size, which defeats the purpose of __dynamic_array(). Looking at the logic, as it already uses __assign_str(), just use the same logic in __string to create the size needed. It appears that because "dev" can be NULL, it needs the check. But __string() can have the same checks as __assign_str() so use them there too. Cc: David Ahern <dsahern@...il.com> Cc: David S. Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org> --- [ This is simpler logic than the fib* events, so I figured just convert to __string() instead of a static __array() ] include/trace/events/neigh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/neigh.h b/include/trace/events/neigh.h index 62bb17516713..5eaa1fa99171 100644 --- a/include/trace/events/neigh.h +++ b/include/trace/events/neigh.h @@ -30,7 +30,7 @@ TRACE_EVENT(neigh_create, TP_STRUCT__entry( __field(u32, family) - __dynamic_array(char, dev, IFNAMSIZ ) + __string(dev, dev ? dev->name : "NULL") __field(int, entries) __field(u8, created) __field(u8, gc_exempt) -- 2.35.1
Powered by blists - more mailing lists