lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8eef927e-27e0-83d0-24a2-20732608788e@gmail.com> Date: Tue, 5 Jul 2022 19:43:58 -0600 From: David Ahern <dsahern@...il.com> To: Steven Rostedt <rostedt@...dmis.org>, LKML <linux-kernel@...r.kernel.org> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH] neighbor: tracing: Have neigh_create event use __string() On 7/5/22 4:37 PM, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" <rostedt@...dmis.org> > > The dev field of the neigh_create event uses __dynamic_array() with a > fixed size, which defeats the purpose of __dynamic_array(). Looking at the > logic, as it already uses __assign_str(), just use the same logic in > __string to create the size needed. It appears that because "dev" can be > NULL, it needs the check. But __string() can have the same checks as > __assign_str() so use them there too. > > Cc: David Ahern <dsahern@...il.com> > Cc: David S. Miller <davem@...emloft.net> > Cc: netdev@...r.kernel.org > Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org> > --- > > [ This is simpler logic than the fib* events, so I figured just > convert to __string() instead of a static __array() ] > agreed. Reviewed-by: David Ahern <dsahern@...nel.org>
Powered by blists - more mailing lists