netdev - Re: [PATCH 6/6] i2c: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220706091315.p5k2jck3rmyjhvqw@skbuf>
Date:   Wed, 6 Jul 2022 12:13:15 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Wolfram Sang <wsa@...nel.org>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-integrity@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-gpio@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, chrome-platform@...ts.linux.dev,
        linux-rpi-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
        patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, linux-mtd@...ts.infradead.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        acpi4asus-user@...ts.sourceforge.net, linux-pm@...r.kernel.org,
        linux-pwm@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-serial@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-watchdog@...r.kernel.org, kasan-dev@...glegroups.com,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void

On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <uwe@...ine-koenig.org>
> 
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
> 
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---

Assuming you remove the spurious kasan change:

Reviewed-by: Vladimir Oltean <olteanv@...il.com>