lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220706093130.cet7y7upl76rp6ug@pengutronix.de>
Date:   Wed, 6 Jul 2022 11:31:30 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Wolfram Sang <wsa@...nel.org>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-integrity@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-gpio@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, chrome-platform@...ts.linux.dev,
        linux-rpi-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
        patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, linux-mtd@...ts.infradead.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        acpi4asus-user@...ts.sourceforge.net, linux-pm@...r.kernel.org,
        linux-pwm@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-serial@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-watchdog@...r.kernel.org, kasan-dev@...glegroups.com,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void

On Wed, Jul 06, 2022 at 12:13:15PM +0300, Vladimir Oltean wrote:
> On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <uwe@...ine-koenig.org>
> > 
> > The value returned by an i2c driver's remove function is mostly ignored.
> > (Only an error message is printed if the value is non-zero that the
> > error is ignored.)
> > 
> > So change the prototype of the remove function to return no value. This
> > way driver authors are not tempted to assume that passing an error to
> > the upper layer is a good idea. All drivers are adapted accordingly.
> > There is no intended change of behaviour, all callbacks were prepared to
> > return 0 before.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
> 
> Assuming you remove the spurious kasan change:

It's already gone in my tree, see
https://git.pengutronix.de/cgit/ukl/linux/commit/?h=i2c-remove-void

> Reviewed-by: Vladimir Oltean <olteanv@...il.com>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ