netdev - Re: [net-next 11/15] net/tls: Multi-threaded calls to TX tls_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a19625bed077cb063aef035ec846e2f6c0d7464.camel@nvidia.com>
Date:   Fri, 8 Jul 2022 13:10:38 +0000
From:   Maxim Mikityanskiy <maximmi@...dia.com>
To:     "ttoukan.linux@...il.com" <ttoukan.linux@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     Tariq Toukan <tariqt@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "saeed@...nel.org" <saeed@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net-next 11/15] net/tls: Multi-threaded calls to TX tls_dev_del

On Thu, 2022-07-07 at 17:17 -0700, Jakub Kicinski wrote:
> On Fri, 8 Jul 2022 01:14:32 +0300 Tariq Toukan wrote:
> > > Why don't we need the flush any more? The module reference is gone as
> > > soon as destructor runs (i.e. on ULP cleanup), the work can still be
> > > pending, no?  

Is this an issue? The work doesn't seem to access any module-level
objects like tls_device_gc_list anymore. Did I miss anything?

> > 
> > So this garbage collector work does not exist anymore. Replaced by 
> > per-context works, with no accessibility to them from this function.
> > It seems that we need to guarantee completion of these works. Maybe by 
> > queuing them to a new dedicated queue, flushing it here.
> 
> Yup, SG.