netdev - RE: [PATCH v4 6/6] can: sja1000: Add support for RZ/N1 SJA1000 CAN Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB5922495C78A7B77874940D2386869@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Tue, 12 Jul 2022 13:03:49 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
CC:     Wolfgang Grandegger <wg@...ndegger.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v4 6/6] can: sja1000: Add support for RZ/N1 SJA1000 CAN
 Controller

Hi Marc,

Thanks for the feedback.

> Subject: Re: [PATCH v4 6/6] can: sja1000: Add support for RZ/N1 SJA1000
> CAN Controller
> 
> On 10.07.2022 12:52:48, Biju Das wrote:
> > The SJA1000 CAN controller on RZ/N1 SoC has no clock divider register
> > (CDR) support compared to others.
> >
> > This patch adds support for RZ/N1 SJA1000 CAN Controller, by adding
> > SoC specific compatible to handle this difference as well as using clk
> > framework to retrieve the CAN clock frequency.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > ---
> > v3->v4:
> >  * Updated commit description.
> >  * Updated clock handling as per bindings.
> > v2->v3:
> >  * No change.
> > v1->v2:
> >  * Updated commit description as SJA1000_NO_HW_LOOPBACK_QUIRK is
> > removed
> >  * Added error handling on clk error path
> >  * Started using "devm_clk_get_optional_enabled" for clk get,prepare
> and enable.
> 
> Due to the use of the devm_clk_get_optional_enabled(), this patch has to
> wait until devm_clk_get_optional_enabled() hits net-next/master, which
> will be probably for the v5.21 merge window.

OK, will wait for 5.21 merge window, as this driver is the first user for this
API.

Cheers,
Biju