netdev - Re: [PATCH stable 4.14 v3] net: dsa: bcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220712220728.zqhq3okafzwz6cvb@skbuf>
Date:   Wed, 13 Jul 2022 01:07:28 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Doug Berger <opendmb@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Sasha Levin <sashal@...nel.org>, netdev@...r.kernel.org,
        andrew@...n.ch
Subject: Re: [PATCH stable 4.14 v3] net: dsa: bcm_sf2: force pause link
 settings

On Tue, Jul 12, 2022 at 12:30:00PM -0700, Florian Fainelli wrote:
> On 7/12/22 12:18, Greg Kroah-Hartman wrote:
> > On Thu, Jul 07, 2022 at 05:14:05PM -0700, Florian Fainelli wrote:
> > > From: Doug Berger <opendmb@...il.com>
> > > 
> > > commit 7c97bc0128b2eecc703106112679a69d446d1a12 upstream
> > > 
> > > The pause settings reported by the PHY should also be applied to the
> > > GMII port status override otherwise the switch will not generate pause
> > > frames towards the link partner despite the advertisement saying
> > > otherwise.
> > > 
> > > Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
> > > Signed-off-by: Doug Berger <opendmb@...il.com>
> > > Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> > > Link: https://lore.kernel.org/r/20220623030204.1966851-1-f.fainelli@gmail.com
> > > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > > ---
> > > Changes in v3:
> > > 
> > > - gate the flow control enabling to links that are auto-negotiated and
> > >    in full duplex
> > > 
> > 
> > Are these versions better / ok now?
> 
> Vladimir "soft" acked it when posting the v3 to v2 incremental diff here:
> 
> https://lore.kernel.org/stable/20220707221537.atc4b2k7fifhvaej@skbuf/
> 
> so yes, these are good now. Thanks and sorry for the noise.
> -- 
> Florian

Sorry, I tend not to leave review tags on backported patches. I should
have left a message stating that I looked at these patches and they look ok.