netdev - Re: [PATCH net-next 0/9] mlx5 devlink mutex removal part 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220711200355.57a9c3da@kernel.org>
Date:   Mon, 11 Jul 2022 20:03:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/9] mlx5 devlink mutex removal part 1

On Mon, 11 Jul 2022 01:13:59 -0700 Saeed Mahameed wrote:
> 1) Fix devlink lock in mlx5 devlink eswitch callbacks
> 
> Following the commit 14e426bf1a4d "devlink: hold the instance lock
> during eswitch_mode callbacks" which takes devlink instance lock for all
> devlink eswitch callbacks and adds a temporary workaround, this patchset
> removes the workaround, replaces devlink API functions by devl_ API
> where called from mlx5 driver eswitch callbacks flows and adds devlink
> instance lock in other driver's path that leads to these functions.
> While moving to devl_ API the patchset removes part of the devlink API
> functions which mlx5 was the last one to use and so not used by any
> driver now.
> 
> The patchset also remove DEVLINK_NL_FLAG_NO_LOCK flag from the callbacks
> of port_new/port which are called only from mlx5 driver and the already
> locked by the patchset as parallel paths to the eswitch callbacks using
> devl_ API functions.
> 
> This patchset will be followed by another patchset that will remove
> DEVLINK_NL_FLAG_NO_LOCK flag from devlink reload and devlink health
> callbacks. Thus we will have all devlink callbacks locked and it will
> pave the way to remove devlink mutex.

Acked-by: Jakub Kicinski <kuba@...nel.org>