netdev - Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42015af3-daa5-7435-725e-8197adbbf3b8@6wind.com>
Date:   Tue, 12 Jul 2022 09:17:48 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Matthias May <matthias.may@...termo.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP
 frames

Le 12/07/2022 à 00:06, Matthias May a écrit :
[snip]
> One thing that puzzles me a bit: Is there any reason why the IPv6 version of ip
> tunnels is so... distributed?
Someone does the factorization for ipv4, but nobody for ipv6 ;-)

> The IPv4 version does everything in a single function in ip_tunnels, while the
> IPv6 delegates some? of the parsing to
> the respective tunnel types, but then does some of the parsing again in
> ip6_tunnel (e.g the ttl parsing).
Note that geneve and vxlan use ip_tunnel_get_dsfield() / ip_tunnel_get_ttl()
which also miss the vlan case.

Regards,
Nicolas