netdev - Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88cbeaff-4300-b2c4-3d00-79918ec88042@westermo.com>
Date:   Tue, 12 Jul 2022 09:51:19 +0200
From:   Matthias May <matthias.may@...termo.com>
To:     <nicolas.dichtel@...nd.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <yoshfuji@...ux-ipv6.org>, <dsahern@...nel.org>,
        <edumazet@...gle.com>, <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP
 frames

On 7/12/22 09:17, Nicolas Dichtel wrote:
> Le 12/07/2022 à 00:06, Matthias May a écrit :
> [snip]
>> One thing that puzzles me a bit: Is there any reason why the IPv6 version of ip
>> tunnels is so... distributed?
> Someone does the factorization for ipv4, but nobody for ipv6 ;-)
> 
>> The IPv4 version does everything in a single function in ip_tunnels, while the
>> IPv6 delegates some? of the parsing to
>> the respective tunnel types, but then does some of the parsing again in
>> ip6_tunnel (e.g the ttl parsing).
> Note that geneve and vxlan use ip_tunnel_get_dsfield() / ip_tunnel_get_ttl()
> which also miss the vlan case.
> 
> Regards,
> Nicolas

Hi Nicolas

Yeah i feared as much.
My plan is to do the selftest for gretap, vxlan and geneve.
Are there any other tunnel types that can carry L2 that i don't know about?

BR
Matthias

Download attachment "OpenPGP_0xDF76B604533C0DBE.asc" of type "application/pgp-keys" (670 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (237 bytes)