netdev - [RFC][PATCH] ipv6/addrconf: allow to use SLAAC with prefixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220715021242.4abdade0@rechenknecht2k11>
Date:   Fri, 15 Jul 2022 02:12:42 +0200
From:   Benjamin Valentin <benjamin.valentin@...pa.com>
To:     netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Subject: [RFC][PATCH] ipv6/addrconf: allow to use SLAAC with prefixes < /64

This enables SLAAC with prefixes smaller than /64.
SLAAC is performed as usual using only the lower 64 bit of the address
for the interface identifier.
The bits not used by the prefix are simply considered 0 (and must be
considered 0 as they will be set by downstream subnets).

The idea is to being able to advertise a larger subnet, that can then
be autonomously split in a hierarchical fashion by downstream routers. [0]

[0] https://github.com/RIOT-OS/RIOT/blob/master/sys/net/gnrc/routing/ipv6_auto_subnets/gnrc_ipv6_auto_subnets.c

Signed-off-by: Benjamin Valentin <benjamin.valentin@...pa.com>
---
 net/ipv6/addrconf.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 49cc6587dd77..aacf01d8cdb6 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2787,8 +2787,9 @@ void addrconf_prefix_rcv(struct net_device *dev, u8 *opt, int len, bool sllao)
 		struct in6_addr addr;
 		bool tokenized = false, dev_addr_generated = false;
 
-		if (pinfo->prefix_len == 64) {
-			memcpy(&addr, &pinfo->prefix, 8);
+		if (pinfo->prefix_len <= 64) {
+			memset(&addr, 0, 8);
+			memcpy(&addr, &pinfo->prefix, (pinfo->prefix_len + 7) / 8);
 
 			if (!ipv6_addr_any(&in6_dev->token)) {
 				read_lock_bh(&in6_dev->lock);