netdev - Re: [PATCH] net: macb: fixup sparse warnings on _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 16:43:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ben Dooks <ben.dooks@...ive.com>
Cc:     linux-kernel@...r.kernel.org,
        Sudip Mukherjee <sudip.mukherjee@...ive.com>,
        Jude Onyenegecha <jude.onyenegecha@...ive.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: macb: fixup sparse warnings on __be16 ports

On Thu, 14 Jul 2022 09:43:05 +0100 Ben Dooks wrote:
> -			htons(fs->h_u.tcp_ip4_spec.psrc), htons(fs->h_u.tcp_ip4_spec.pdst));
> +		        be16_to_cpu(fs->h_u.tcp_ip4_spec.psrc),
> +		        be16_to_cpu(fs->h_u.tcp_ip4_spec.pdst));

There are some spaces on this line, please use tabs,
checkpatch will be able to help you validate.