netdev - Re: [RFC PATCH net-next v3] net: virtio_net: notifications coalescing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJs=3_DjiMZm+Yf8bwoRAn+=uKpiNToCRMWGuemPWFyPCtuMhw@mail.gmail.com>
Date:   Sun, 17 Jul 2022 09:24:36 +0300
From:   Alvaro Karsz <alvaro.karsz@...id-run.com>
To:     netdev <netdev@...r.kernel.org>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [RFC PATCH net-next v3] net: virtio_net: notifications coalescing support

If VIRTIO_NET_F_NOTF_COAL is negotiated, and we try to change the
coalescing parameters when the link is up,
the control commands will be sent to the device, but the
virtnet_set_coalesce function will return -EBUSY anyway.

I'll fix it in the next version by checking if the link is up before
sending the control commands.

BTW, the VirtIO patch was merged, so the next version won't be tagged as RFC.