netdev - Re: [patch net-next 6/9] mlxsw: convert driver to use unlocked devlink API during init/fini

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtO79H0VleQHfMUC@shredder>
Date:   Sun, 17 Jul 2022 10:36:20 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, mlxsw@...dia.com,
        saeedm@...dia.com, moshe@...dia.com, tariqt@...dia.com
Subject: Re: [patch net-next 6/9] mlxsw: convert driver to use unlocked
 devlink API during init/fini

On Sat, Jul 16, 2022 at 01:02:38PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Prepare for devlink reload being called with devlink->lock held and
> convert the mlxsw driver to use unlocked devlink API during init and
> fini flows. Take devl_lock() in reload_down() and reload_up() ops in the
> meantime before reload cmd is converted to take the lock itself.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>
Tested-by: Ido Schimmel <idosch@...dia.com>

It is getting hard to review changes in mlxsw_core_bus_device_register()
and mlxsw_core_bus_device_unregister() with all these reload checks.
Probably best if I convert it to something similar to netdevsim's
implementation after the devlink overhaul.